add a comment so the checking of encoding the zero value might be ena…

…bled again when ticket hyperledger#4284 is worked on Signed-off-by: Stefan <stefan.pingel@consensys.net>
pinges · Aug 23, 2022 · 2a6745d · 2a6745d
1 parent f2537f7
commit 2a6745d
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/.../p2p/src/test/java/org/hyperledger/besu/ethereum/p2p/rlpx/wire/WireMessagesSedesTest.java b/.../p2p/src/test/java/org/hyperledger/besu/ethereum/p2p/rlpx/wire/WireMessagesSedesTest.java
@@ -54,6 +54,8 @@ public void deserializeHello() {
   }
 
   private static void assertSedesWorks(final byte[] data, final boolean encEqualsInput) {
+    // TODO: the boolean was added because we do encode the version number 0 as 0x00, not as 0x80
+    // Ticket #4284 to address the broader issue of encoding/decoding zero
     final Bytes input = Bytes.wrap(data);
 
     final PeerInfo peerInfo = PeerInfo.readFrom(RLP.input(input));