*: Use strict validation for stale read ts & flashback ts (#57050) #58409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
ok-to-test
13 tasks
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
size/XXL
ti-chi-bot
bot
added
cherry-pick-approved
ekexium
force-pushed
the
cherry-pick-57050-to-release-6.5
branch
from
9ea565e to
24d5d36
Compare
ti-chi-bot
bot
added
size/XL
ekexium
force-pushed
the
cherry-pick-57050-to-release-6.5
branch
2 times, most recently
from
1eb5b3e to
d8655c0
Compare
ekexium
force-pushed
the
cherry-pick-57050-to-release-6.5
branch
from
d8655c0 to
aa9ba4c
Compare
ti-chi-bot
bot
added
size/L
ekexium
approved these changes
Jan 16, 2025
ti-chi-bot
bot
added
needs-1-more-lgtm
cfzjywxk
approved these changes
Jan 16, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, ekexium The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
ekexium
force-pushed
the
cherry-pick-57050-to-release-6.5
branch
from
61710ce to
b02c042
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #58409 +/- ##
================================================
Coverage ? 73.6224%
================================================
Files ? 1097
Lines ? 353046
Branches ? 0
================================================
Hits ? 259921
Misses ? 76388
Partials ? 16737 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #57050
What problem does this PR solve?
Issue Number: close #56809
Problem Summary:
What changed and how does it work?
Use strict check for stale read ts & flashback ts to avoid any reading on future ts, which has risk to break the linearizability of async commit and 1PC transactions.
Pending and waiting for tikv/client-go#1484
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.