Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: add more retry strategy (s3.ReadFile: body reader / pushBackup: backoffer) #50541

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Jan 18, 2024

What problem does this PR solve?

Issue Number: close #49942

Problem Summary:
backup/restore failed for external storage error

What changed and how does it work?

add more retry strategy (s3.ReadFile: body reader / pushBackup: backoffer)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Jan 18, 2024
Copy link

tiprow bot commented Jan 18, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Merging #50541 (0101e48) into master (0568385) will decrease coverage by 14.6962%.
Report is 4 commits behind head on master.
The diff coverage is 68.2539%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50541         +/-   ##
=================================================
- Coverage   70.3389%   55.6427%   -14.6963%     
=================================================
  Files          1456       1567        +111     
  Lines        420707     589399     +168692     
=================================================
+ Hits         295921     327958      +32037     
- Misses       104456     238605     +134149     
- Partials      20330      22836       +2506     
Flag Coverage Δ
integration 36.7135% <12.6984%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 56.5393% <68.2539%> (+6.0101%) ⬆️

Leavrth and others added 2 commits January 24, 2024 16:17
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2024
@BornChanger
Copy link
Contributor

/label needs-cherry-pick-release-6.5

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 24, 2024
@BornChanger
Copy link
Contributor

/label needs-cherry-pick-release-7.1

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Jan 24, 2024
@BornChanger
Copy link
Contributor

/label needs-cherry-pick-release-7.5

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jan 24, 2024
Copy link

ti-chi-bot bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2024
Copy link

ti-chi-bot bot commented Jan 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-24 08:49:38.926470131 +0000 UTC m=+950620.490767836: ☑️ agreed by YuJuncen.
  • 2024-01-24 09:53:13.391700751 +0000 UTC m=+954434.955998456: ☑️ agreed by 3pointer.

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot merged commit d6ef1c7 into pingcap:master Jan 24, 2024
24 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 24, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #50706.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 24, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #50707.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #50708.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 24, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Feb 4, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backup/restore: handle external storage error gracefully
5 participants