-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: fix decode issue for prefetch point plan index keys #50037
server: fix decode issue for prefetch point plan index keys #50037
Conversation
Hi @tangenta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50037 +/- ##
================================================
- Coverage 71.9599% 68.8249% -3.1350%
================================================
Files 1438 1440 +2
Lines 345794 409173 +63379
================================================
+ Hits 248833 281613 +32780
- Misses 76727 108521 +31794
+ Partials 20234 19039 -1195
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@mornyx PTAL |
[LGTM Timeline notifier]Timeline:
|
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, Defined2014, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold cc @Defined2014 |
/unhold |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #50012
Problem Summary:
The second parameter of
tablecodec.DecodeHandleInUniqueIndexValue
indicates whether index KVs belong to a clustered-index table. Previously, it was alwaysfalse
, causing decoding error and panic.What changed and how does it work?
BatchGet req does not set the resource tag, tid: 123, stack: goroutine 20153 [running]
, I also set the resource group tagger by the digest of all SQLs.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.