Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: return an error when using prepared protocol with select-into statement (#49357) #49365

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49357

What problem does this PR solve?

Issue Number: close #49166

Problem Summary: planner: return an error when using prepared protocol with select-into statement

What changed and how does it work?

Limited by the current implementation, prepared protocol cannot support select-into statements, otherwise might cause some wrong results, return an error directly in this case.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@cf7a0af). Click here to learn what that means.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #49365   +/-   ##
================================================
  Coverage               ?   74.3349%           
================================================
  Files                  ?       1404           
  Lines                  ?     426078           
  Branches               ?          0           
================================================
  Hits                   ?     316725           
  Misses                 ?      90248           
  Partials               ?      19105           
Flag Coverage Δ
unit 74.3349% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 54.0158% <0.0000%> (?)

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 1, 2024
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 20, 2024
Copy link

ti-chi-bot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 20, 2024
Copy link

ti-chi-bot bot commented Feb 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-20 04:05:28.135969699 +0000 UTC m=+330016.883592810: ☑️ agreed by fixdb.
  • 2024-02-20 04:18:37.478710953 +0000 UTC m=+330806.226334049: ☑️ agreed by qw4990.

@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/test check_dev_2

Copy link

ti-chi-bot bot commented Feb 20, 2024

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-br-integration-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/release-7.5/ghpr_build
  • pingcap/tidb/release-7.5/ghpr_check
  • pingcap/tidb/release-7.5/ghpr_check2
  • pingcap/tidb/release-7.5/ghpr_mysql_test
  • pingcap/tidb/release-7.5/ghpr_unit_test

In response to this:

/test check_dev_2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/test check-dev2

Copy link

tiprow bot commented Feb 20, 2024

@qw4990: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test check_dev_2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Feb 20, 2024

@qw4990: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/test mysql-test

Copy link

tiprow bot commented Feb 20, 2024

@qw4990: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/test check-dev2

Copy link

tiprow bot commented Feb 20, 2024

@qw4990: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/retest

@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/retest

3 similar comments
@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/retest

@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/retest

@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/retest

@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/test check-dev2

Copy link

tiprow bot commented Feb 20, 2024

@qw4990: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit aba09b9 into pingcap:release-7.5 Feb 20, 2024
11 checks passed
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Feb 21, 2024
Copy link

ti-chi-bot bot commented Feb 21, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved do-not-merge/cherry-pick-not-approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants