-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: return an error when using prepared protocol with select-into statement (#49357) #49365
planner: return an error when using prepared protocol with select-into statement (#49357) #49365
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #49365 +/- ##
================================================
Coverage ? 74.3349%
================================================
Files ? 1404
Lines ? 426078
Branches ? 0
================================================
Hits ? 316725
Misses ? 90248
Partials ? 19105
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fixdb, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test check_dev_2 |
@qw4990: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test check-dev2 |
@qw4990: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@qw4990: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test mysql-test |
@qw4990: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test check-dev2 |
@qw4990: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/retest |
3 similar comments
/retest |
/retest |
/retest |
/test check-dev2 |
@qw4990: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #49357
What problem does this PR solve?
Issue Number: close #49166
Problem Summary: planner: return an error when using prepared protocol with select-into statement
What changed and how does it work?
Limited by the current implementation, prepared protocol cannot support select-into statements, otherwise might cause some wrong results, return an error directly in this case.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.