Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix AnalyzePartitionMergeConcurrency unavailable #47589

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Oct 12, 2023

What problem does this PR solve?

Issue Number: close #47594

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Oct 12, 2023
@hawkingrei hawkingrei added skip-issue-check Indicates that a PR no need to check linked issue. do-not-merge/needs-tests-checked and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 12, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #47589 (f7f5288) into master (14d3cb5) will increase coverage by 0.8887%.
Report is 6 commits behind head on master.
The diff coverage is 33.3333%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47589        +/-   ##
================================================
+ Coverage   71.8879%   72.7766%   +0.8887%     
================================================
  Files          1353       1375        +22     
  Lines        401070     407485      +6415     
================================================
+ Hits         288321     296554      +8233     
+ Misses        93329      92124      -1205     
+ Partials      19420      18807       -613     
Flag Coverage Δ
integration 40.5718% <33.3333%> (?)
unit 71.9322% <33.3333%> (+0.0443%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.7328% <ø> (ø)
br 49.0554% <ø> (-4.3225%) ⬇️

@hawkingrei hawkingrei changed the title *: add test for AnalyzePartitionMergeConcurrency *: fix AnalyzePartitionMergeConcurrency Oct 12, 2023
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei changed the title *: fix AnalyzePartitionMergeConcurrency *: fix AnalyzePartitionMergeConcurrency unavailable Oct 12, 2023
@hawkingrei hawkingrei removed the skip-issue-check Indicates that a PR no need to check linked issue. label Oct 12, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-12 13:27:22.265629381 +0000 UTC m=+1318039.852739526: ☑️ agreed by qw4990.
  • 2023-10-12 14:22:16.543188668 +0000 UTC m=+1321334.130298812: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit 7a371dd into pingcap:master Oct 12, 2023
@hawkingrei hawkingrei deleted the concurrency branch November 13, 2023 07:31
@hawkingrei
Copy link
Member Author

/cherrypick release-6.5
/cherrypick release-7.1

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-6.5: #51140.

In response to this:

/cherrypick release-6.5
/cherrypick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 19, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.1: #51141.

In response to this:

/cherrypick release-6.5
/cherrypick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 19, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnalyzePartitionMergeConcurrency cannot be abled
5 participants