-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta/autoid: enable etcd client auto sync for autoid service (#43529) #43532
meta/autoid: enable etcd client auto sync for autoid service (#43529) #43532
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hawkingrei The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #43529
What problem does this PR solve?
Issue Number: close #42643
ref #9575, ref #33908
Problem Summary:
When the pd server change, the corresponding etcd address should be auto-refresh on the client side.
What is changed and how it works?
Because 1. tidb repo is too big, and it's not designed to be used as a lib. (this applies to all tidb/util/xxx), so the etcd client utility in the tidb repo is not a good place to be shared by other repos (tools / binlog ...)
2. For autoid service, it's a indenpendent component, the code is put to the tidb repo though. So this case is similiar to tools etc.
It should have shared the same etcd client instance, but it's not available when the server startup.
Maybe we can maintain a
pingcap/etcdutil
lib to solve the " 4 different etcd clients" issueCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.