-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: remove the useless variable tidb_enable_point_get_cache
#36844
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@fzzf678: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a4d2c12
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2a11a1e644db8ddc99847e82be4a1c9831dbbb66 |
/merge |
@dayicklp: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
/merge |
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
There is a compatibility feature for removed variables here: https://github.com/pingcap/tidb/blob/master/sessionctx/variable/removed.go -- did you want to add this? |
What problem does this PR solve?
Issue Number: close #36598
Problem Summary: planner: remove the useless variable
tidb_enable_point_get_cache
What is changed and how it works?
planner: remove the useless variable
tidb_enable_point_get_cache
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.