-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: refactor the execute path when using plan cache #36587
planner: refactor the execute path when using plan cache #36587
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/8a2ef77b462c01b20a0ae6c0ded0f8e1e47be766 |
…r-getPhysicalPlan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The short path caused a lot of trouble when I am coding stale read.
There may be a little performance regression after removing this short path, but we'll fix it by cleaning the code path of Plan Cache later. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 407657f
|
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: ref #36598
Problem Summary:
Remove the short path for the PointGet when execute
execute
statement. We will optimize theoptimize
function for execute statement in the later PR.What is changed and how it works?
Remove the short path for the PointGet when execute
execute
statement.Check List
Tests
Current existing test cases can cover this PR
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.