Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): delete the useless go.mod file in tools/check folder #1303

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Jun 12, 2024

We can just use go run to run the ci linter.

Signed-off-by: wuhuizuo wuhuizuo@126.com

What problem does this PR solve?

Issue Number: close #1304

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

Release note

None

We can just use `go run` to run the ci linter.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@wuhuizuo
Copy link
Contributor Author

/label release-note-none

Copy link

ti-chi-bot bot commented Jun 12, 2024

@wuhuizuo: The label(s) release-note-none cannot be applied. These labels are supported: contribution, duplicate, feature-request, first-time-contributor, invalid, need-update-ansible, need-update-docs, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, needs-cherry-pick-release-8.1, p0, p1, p2, question, wontfix.

In response to this:

/label release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wuhuizuo
Copy link
Contributor Author

/release-note none

@wuhuizuo
Copy link
Contributor Author

/cc Benjamin2037

@ti-chi-bot ti-chi-bot bot requested a review from Benjamin2037 June 12, 2024 06:46
@wuhuizuo
Copy link
Contributor Author

/run-integration-test

Copy link

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jun 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-12 07:30:57.89179182 +0000 UTC m=+536211.945103745: ☑️ agreed by Benjamin2037.
  • 2024-06-12 07:48:01.511467553 +0000 UTC m=+537235.564779474: ☑️ agreed by nongfushanquan.

@ti-chi-bot ti-chi-bot bot merged commit f4220eb into pingcap:master Jun 12, 2024
6 checks passed
@wuhuizuo wuhuizuo deleted the ci/fix-check-tools-deps branch June 12, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make CI be simpler
3 participants