This repository has been archived by the owner on Jan 3, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
zh: add a document about how to optimize config #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csuzhangxc
reviewed
May 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>
toutdesuite
reviewed
May 21, 2020
Co-authored-by: toutdesuite <guizhiluo2014@163.com>
csuzhangxc
reviewed
May 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: toutdesuite <guizhiluo2014@163.com>
toutdesuite
reviewed
May 22, 2020
toutdesuite
reviewed
May 22, 2020
toutdesuite
reviewed
May 22, 2020
miaoqingli
approved these changes
May 22, 2020
LGTM |
Co-authored-by: toutdesuite <guizhiluo2014@163.com>
lilin90
reviewed
May 22, 2020
lilin90
approved these changes
May 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lilin90
added a commit
that referenced
this pull request
May 27, 2020
* scripts: add a script to run markdownlint check locally (#74) * Update ci.yaml (#84) * zh: update TOC (#75) * update TOC * Update TOC.md * Update TOC.md * Update zh/TOC.md Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update zh/TOC.md Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> * address comments * fix dead link and address comment * Apply suggestions from code review * fix levels * Update links in TOC * fix CI * remove link for 测试验证 Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: yikeke <yikeke@pingcap.com> * zh: add the requirement of software and hardware (#76) * add requirement * Apply suggestions from code review Co-authored-by: toutdesuite <guizhiluo2014@163.com> * update word * address comemnt * Apply suggestions from code review Co-authored-by: Lilian Lee <lilin@pingcap.com> * update disk requirement * Apply suggestions from code review Co-authored-by: toutdesuite <guizhiluo2014@163.com> * rename file name * Apply suggestions from code review Co-authored-by: Lilian Lee <lilin@pingcap.com> * address comment Co-authored-by: toutdesuite <guizhiluo2014@163.com> Co-authored-by: Lilian Lee <lilin@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> * zh: update documents about error handling (#78) * zh: add a document about performance handling (#81) * zh: add document about creating task and verify (#77) * zh: add quick start doc for dm deployment (#80) * zh: update docs about key features (#86) * zh: add a document about how to optimize config (#89) * add config optimize * rename file * Apply suggestions from code review Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com> * format * address comment * Apply suggestions from code review Co-authored-by: toutdesuite <guizhiluo2014@163.com> * Apply suggestions from code review Co-authored-by: toutdesuite <guizhiluo2014@163.com> * Update zh/tune-configuration.md * Apply suggestions from code review Co-authored-by: toutdesuite <guizhiluo2014@163.com> * Update zh/tune-configuration.md Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com> Co-authored-by: toutdesuite <guizhiluo2014@163.com> Co-authored-by: Lilian Lee <lilin@pingcap.com> * zh: Further update TOC.md (#92) * Update TOC.md * add omitted links * update format * Update TOC.md * Update TOC.md * Update zh/TOC.md Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> * update file name * add alias * fix dead links * Revert "fix dead links" This reverts commit 9cf7b75. * fix dead links in zh Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> * zh: update dm-upgrade (#87) * zh: add a document about scenarios (#88) * zh: update daily-check.md (#91) * update daily-check.md * address comment * address comment * Update zh/daily-check.md * Update zh/daily-check.md Co-authored-by: toutdesuite <guizhiluo2014@163.com> * Update zh/daily-check.md Co-authored-by: toutdesuite <guizhiluo2014@163.com> * Update zh/daily-check.md Co-authored-by: toutdesuite <guizhiluo2014@163.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: toutdesuite <guizhiluo2014@163.com> Co-authored-by: WangXiangUSTC <wx347249478@gmail.com> * zh: update docs about alert rules and handling (#93) * zh: add a doc about command-line-flags and update TOC (#94) * zh: add a doc about command-line-flags and update TOC * zh: update TOC * command-line-flags: address comments * Update zh/command-line-flags.md Co-authored-by: toutdesuite <guizhiluo2014@163.com> * Update zh/command-line-flags.md Co-authored-by: toutdesuite <guizhiluo2014@163.com> * Update zh/command-line-flags.md Co-authored-by: toutdesuite <guizhiluo2014@163.com> * command-line-flags: address comments * remove empty files Co-authored-by: toutdesuite <guizhiluo2014@163.com> * zh: add files about manage task (#90) * add task manage for special week * minor change * rename file * rename file * minor change * minor change * fix CI * fix CI * address comment * minor change * Update skip-or-replace-abnormal-sql-statements.md * Update zh/create-task.md Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com> * address comment * address comment * update TOC * address comment * Update TOC.md * add query-status and query-error in TOC * fix toc * Update zh/query-error.md Co-authored-by: Lilian Lee <lilin@pingcap.com> * Update zh/query-status.md Co-authored-by: Lilian Lee <lilin@pingcap.com> * rm manage-replication-tasks.md * fix CI * fix CI * address comment * fix bug * update TOC * add dmctl-intro.md * Update zh/dmctl-intro.md Co-authored-by: toutdesuite <guizhiluo2014@163.com> * rename file * Update TOC.md * address comment Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com> Co-authored-by: toutdesuite <guizhiluo2014@163.com> Co-authored-by: Lilian Lee <lilin@pingcap.com> Co-authored-by: WangXiangUSTC <wx347249478@gmail.com> * zh: add document about how to do performance test (#85) * zh: update TOC and remove empty files (#95) * update TOC and remove empty files * Update TOC.md Co-authored-by: yikeke <yikeke@pingcap.com> * zh: update release notes in toc * zh: update wording * *: make image name unique at the repo level (#96) * *: make image name unique at repo level * en: fix one link Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: toutdesuite <guizhiluo2014@163.com> Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: WangXiangUSTC <wx347249478@gmail.com> Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com> Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn> Co-authored-by: GMHDBJD <35025882+GMHDBJD@users.noreply.github.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
size/medium
Changes of a medium size.
special-week
PR from Document Special Week.
status/PTAL
This PR is ready for reviewing.
translation/done
This PR has been translated.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
add a document about how to optimize config
Which TiDB Data Migration (DM) version(s) do your changes apply to? (Required)