-
Notifications
You must be signed in to change notification settings - Fork 63
en: add document about how to do performance test #131
Conversation
Co-authored-by: Ran <huangran@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
en/performance-test.md
Outdated
mydumper-config-name: "global" | ||
loader-thread: 16 | ||
|
||
# Configure the name of the library where sysbench generates data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to change library
to database
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on the actual meaning of the Chinese version. Is it library
or database
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this means database name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Let's use database
@toutdesuite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in d0cddfb~
Co-authored-by: Ran <huangran@pingcap.com>
…s-dm into performance-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
What is changed, added or deleted? (Required)
benchmark-v1.0-ga.md
Which DM version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?