Skip to content
This repository has been archived by the owner on Jan 3, 2025. It is now read-only.

en: add document about how to do performance test #131

Merged
merged 13 commits into from
Jul 20, 2020

Conversation

toutdesuite
Copy link
Contributor

@toutdesuite toutdesuite commented Jun 28, 2020

What is changed, added or deleted? (Required)

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v2.0 changes for now)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

@toutdesuite toutdesuite marked this pull request as draft June 28, 2020 07:25
@toutdesuite toutdesuite added the translation/from-zh This PR is translated from a PR in docs-dm/zh. label Jul 10, 2020
@toutdesuite toutdesuite marked this pull request as ready for review July 10, 2020 05:39
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2020
mydumper-config-name: "global"
loader-thread: 16

# Configure the name of the library where sysbench generates data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to change library to database?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on the actual meaning of the Chinese version. Is it library or database?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this means database name

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Let's use database @toutdesuite

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in d0cddfb~

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 18, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 18, 2020
@toutdesuite
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@toutdesuite toutdesuite merged commit 9dd62cc into pingcap:master Jul 20, 2020
@toutdesuite toutdesuite deleted the performance-test branch July 20, 2020 03:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-zh This PR is translated from a PR in docs-dm/zh.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants