dns.revServers still insists on <domain>

[XnS]

Versions

• Core version is v6.0.1 (Latest: v6.0.1)
• Web version is v6.0 (Latest: v6.0)
• FTL version is v6.0 (Latest: v6.0)

Platform

• OS and version:

PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian

• Platform: Raspberry Pi 4 Model B Rev 1.4

Expected behavior

1. Add conditional forwarding rule without domain, for example:

true,192.168.20.0/24,192.168.20.1

2. Save settings
3. Config validator shows no errors
4. PTR is forwarded to 192.168.20.1

Actual behavior / bug

1. Add conditional forwarding rule without domain, for example:

true,192.168.20.0/24,192.168.20.1

2. Save settings
3. Config validator shows no errors
4. FTL.log prints

2025-02-20 17:52:54.233 GMT [1866M] ERROR: Skipped invalid dns.revServers[0]: true,192.168.20.0/24,192.168.20.1

5. Query response is

➜  ~ host 192.168.20.188
Host 188.20.168.192.in-addr.arpa. not found: 3(NXDOMAIN)

Steps to reproduce

see above

Debug Token

• URL: n/a

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

With #2115 there was a report, that the domain is considered required although the documentation states it's optional.
With #2116 the config validator has been updated to treat domain as optional.

The dnsmasq config writer however still expects the domain to be set:

FTL/src/config/dnsmasq_config.c

Lines 503 to 508 in eaa7dbb

	if(active == NULL || cidr == NULL || target == NULL || domain == NULL)
	{
	log_err("Skipped invalid dns.revServers[%u]: %s", i, revServer->valuestring);
	free(copy);
	continue;
	}

[DL6ER]

Oh yes, I am sorry, the fix is here, a more detailed description is therein: #2237

If you already want to try it out, please use

sudo pihole checkout ftl fix/revServer_wo_domain

[XnS]

Works, thank you for the quick fix 👍

[XhmikosR]

Confirmed it works too, by editing pihole.toml manually.

But it seems that the migration from v5 added a trailing comma without the domain since it was missing, not sure if that is valid or not now.

[DL6ER]

#2248 should be this final fix for this.

[XhmikosR]

Thanks!

…

On Sat, Feb 22, 2025, 12:33 Dominik ***@***.***> wrote: #2248 <#2248> should be this final fix for this. — Reply to this email directly, view it on GitHub <#2216 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACVLNN4EGMQTJ33ZWS5NE32RBG6JAVCNFSM6AAAAABXRNPDH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZWGEZTQNJWGA> . You are receiving this because you commented.Message ID: ***@***.***> [image: DL6ER]*DL6ER* left a comment (pi-hole/FTL#2216) <#2216 (comment)> #2248 <#2248> should be this final fix for this. — Reply to this email directly, view it on GitHub <#2216 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACVLNN4EGMQTJ33ZWS5NE32RBG6JAVCNFSM6AAAAABXRNPDH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZWGEZTQNJWGA> . You are receiving this because you commented.Message ID: ***@***.***>

[XhmikosR]

Would it also make sense to remove any trailing commas to take care of any previous broken migrations?

…

On Sat, Feb 22, 2025, 13:06 XhmikosR ***@***.***> wrote: Thanks! On Sat, Feb 22, 2025, 12:33 Dominik ***@***.***> wrote: > #2248 <#2248> should be this final > fix for this. > > — > Reply to this email directly, view it on GitHub > <#2216 (comment)>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AACVLNN4EGMQTJ33ZWS5NE32RBG6JAVCNFSM6AAAAABXRNPDH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZWGEZTQNJWGA> > . > You are receiving this because you commented.Message ID: > ***@***.***> > [image: DL6ER]*DL6ER* left a comment (pi-hole/FTL#2216) > <#2216 (comment)> > > #2248 <#2248> should be this final > fix for this. > > — > Reply to this email directly, view it on GitHub > <#2216 (comment)>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AACVLNN4EGMQTJ33ZWS5NE32RBG6JAVCNFSM6AAAAABXRNPDH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZWGEZTQNJWGA> > . > You are receiving this because you commented.Message ID: > ***@***.***> >

[DL6ER]

I don't think we need to remove trailing commas, they should have no negative effects.

This issue is now fixed in FTL v6.0.3. Please all go back to master using

sudo pihole checkout ftl master

in case you switched to a special branch in the course of this issue. The special branch is now abandoned and won't receive updates in the future.