Upgrade to nikic/php-parser:^5.0
#233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanerkay
changed the title
nikic/php-parser:^5.0nikic/php-parser:^5.0
|
phpdoc-parser does not depend on nikic/PHP-Parser. It's only in require-dev. If you're getting an error message about a conflict in Composer, it's not a fault of phpdoc-parser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/nikic/PHP-Parser/blob/master/UPGRADE-5.0.md
notably a php 7.4 version requirement
if we want to retain php 7.2/7.3 support, we could support both v4.0 and v5.0, but given that the main phpstan repo already requires php 8.1, I think this is fine, given the age of php 7.3 (end of life since over 2 years)