Back up & restore old git hooks #456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SerkanYildiz
commented
Jan 30, 2018
•
SerkanYildiz
commented
| Q | A |
|---|---|
| Branch | master |
| Bug fix? | no |
| New feature? | kind of |
| BC breaks? | no |
| Deprecations? | no |
| Documented? | n/a |
| Fixed tickets | #416 |
SerkanYildiz
changed the title
SerkanYildiz
changed the title
| * | ||
| * @return void | ||
| * | ||
| * @throws \Symfony\Component\Filesystem\Exception\IOException |
There was a problem hiding this comment.
FQDN (Multiple places)
|
This is good, but it does not fix #416. With this PR or without grumphp will still corrupt my hooks. |
veewee
reviewed
Apr 5, 2018
There was a problem hiding this comment.
Hi @SerkanYildiz,
Thanks for your work. As I explained in #416, I think this PR is not necesarry and will cause some maintenance overkill. Lets keep this open for now and see where the discussion in the issue will lead us.
|
@SerkanYildiz. We will close this PR. There is a note in the README that your existing git hooks will be overwritten. Thanks for the effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.