Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recommended constraint #92

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Use recommended constraint #92

merged 3 commits into from
Dec 13, 2021

Conversation

dereuromark
Copy link
Contributor

@dereuromark dereuromark commented Dec 4, 2021

Problem 1
- phpdocumentor/graphviz 2.0.0 requires php ^7.2 || 8.0.* -> your php version (8.1.0) does not satisfy that requirement.

Blocks several apps and libraries trying to use this lib

Note: Config locking of PHP versions is not recommended for libs, only for projects
As it also prevents proper testing of higher versions of libs against your code.
Use prefer lowest instead on top.

@dereuromark
Copy link
Contributor Author

@jaapio Are we able to make a patch release here? This would unblock a few libraries and projects of ours to get tested on 8.1+

@jaapio
Copy link
Member

jaapio commented Dec 13, 2021

I think we can :-) but not right now as I'm just passing by.

@dereuromark
Copy link
Contributor Author

The unrelated CS issues in CI should be done in a separate PR.

@gggeek
Copy link

gggeek commented Dec 13, 2021

+1

Copy link
Member

@jaapio jaapio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok, for me now.
Thanks!

@jaapio jaapio merged commit d02be07 into phpDocumentor:master Dec 13, 2021
@dereuromark dereuromark deleted the patch-1 branch December 13, 2021 18:59
@jaapio
Copy link
Member

jaapio commented Dec 13, 2021

Release done :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants