Avoid using 2.3x the image size worth of memory when no memory is enough #479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exif_read_data can read from the filesystem just fine, so if we get an image path, doing file_get_contents() will load up the file in memory, and then passing it to doReadData will base64_encode it which typically adds 1/3rd of the binary size to the output, so you add 1.3x the image size into the memory.
This is all fine with thumbnail sized images but when dealing with large files you very easily and unnecessarily blow up the memory limit.
There is no 0.6 branch but this applies cleanly on 0.6.3 as well, in case you'd like to do a new release :)