Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Commit

Permalink
Refactor header dialogs
Browse files Browse the repository at this point in the history 
Closes #130

* Remove hard-coded modal dialog HTML code
* Use Dialog class instead

Breaking changes might be:
* dialog id to class
   * `#headerAboutDialog` -> `.header-about-dialog`
   * `#headerReportBugDialog` -> `.header-report-bug-dialog`
   * `#headerOptionsDialog` -> `.header-options-dialog`
* Make link toggle functions private (`toggleOptionsLink`, `toggleReportBugLink`, `toggleHelpLink`)
* About dialog: `content` parameter of content generator function is now empty -> default HTML is only generated by `defaultAboutInfo()`
  • Loading branch information
@thinkh
thinkh committed Jan 4, 2021
1 parent 1ac2274 commit 50a70dd
Show file tree
Hide file tree
Showing 6 changed files with 193 additions and 270 deletions.
26 changes: 12 additions & 14 deletions dist/components/header.d.ts
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

180 changes: 69 additions & 111 deletions dist/components/header.js
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 50a70dd

Please sign in to comment.