Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewer: Add button to open the edit dialog #4701

Open
1 of 2 tasks
lastzero opened this issue Jan 7, 2025 · 0 comments
Open
1 of 2 tasks

Viewer: Add button to open the edit dialog #4701

lastzero opened this issue Jan 7, 2025 · 0 comments
Assignees
@AsikNasik
Labels
enhancement Refactoring, improvement or maintenance task frontend Requires experience with HTML/JS/CSS tested Changes have been tested successfully ux Impacts User Experience

Comments

@lastzero
Copy link
Member

lastzero commented Jan 7, 2025 •
edited
Loading

As a PhotoPrism user, I would like to see the following implemented for the new Hybrid Photo/Video Viewer in component/viewer.vue before releasing it:

  • If the current user has the necessary permissions, add a button at the top to open the current picture in the Edit dialog. The edit button should look and work similar to the one in the current stable release (see screenshot below).

favorite-toggle

Additional Improvements:

  • Once this is implemented, a great improvement would be to make the buttons at the top responsive, so that e.g. the edit button/link can be displayed in a "three dot" menu on small screens, and only the most important actions/buttons are always visible at the top (see example below). If unsure, please test, discuss, and suggest alternative implementations before committing to a specific approach.

dots

Related Issues:

New Edit Dialog:

Image
@lastzero lastzero added enhancement Refactoring, improvement or maintenance task frontend Requires experience with HTML/JS/CSS ux Impacts User Experience labels Jan 7, 2025
This was referenced Jan 7, 2025
Open
Open
Open
Open
Open
AsikNasik pushed a commit that referenced this issue Jan 8, 2025
Feature: add a Button to Open the Edit Dialog #4701
6bdb0d2
@AsikNasik AsikNasik mentioned this issue Jan 8, 2025
Merged
@graciousgrey graciousgrey added the in-progress Somebody is working on this label Jan 8, 2025
@graciousgrey graciousgrey moved this to Development 🐝 in Roadmap 🚀✨ Jan 8, 2025
@AsikNasik AsikNasik self-assigned this Jan 8, 2025
@AsikNasik AsikNasik added the please-test Ready for acceptance test label Jan 8, 2025
@AsikNasik AsikNasik assigned omerdduran and lastzero and unassigned lastzero and omerdduran Jan 8, 2025
AsikNasik pushed a commit that referenced this issue Jan 8, 2025
Fix: fix method in function onEdit #4701
5f6b23e
@AsikNasik AsikNasik removed the in-progress Somebody is working on this label Jan 8, 2025
AsikNasik pushed a commit that referenced this issue Jan 8, 2025
Feature: add a Button to Open the Edit Dialog #4701
917b28f
AsikNasik pushed a commit that referenced this issue Jan 8, 2025
Fix: fix method in function onEdit #4701
c6243b8
AsikNasik added a commit that referenced this issue Jan 8, 2025
@AsikNasik
Feature: add a Button to Open the Edit Dialog #4701
9e45dd5
AsikNasik added a commit that referenced this issue Jan 8, 2025
@AsikNasik
Fix: fix method in function onEdit #4701
de3f6f2
AsikNasik added a commit that referenced this issue Jan 8, 2025
@AsikNasik
Merge pull request #4706 from photoprism/feature/add-a-Button-to-Open…
7ae3921 
…-the-Edit-Dialog-#4701

Viewer: Add a Button to Open the Edit Dialog #4701
@AsikNasik AsikNasik added please-test Ready for acceptance test and removed please-test Ready for acceptance test labels Jan 8, 2025
AsikNasik added a commit that referenced this issue Jan 8, 2025
@AsikNasik
Viewer: add a Toggle to flag/unflag pictures as Favorite #4701
0abbaab
AsikNasik added a commit that referenced this issue Jan 9, 2025
@AsikNasik
Viewer: add a Toggle to flag/unflag pictures as Favorite #4701
f2bfc36
@lastzero lastzero changed the title Viewer: Add a Button to Open the Edit Dialog Viewer: Add button to open the edit dialog Jan 11, 2025
@lastzero lastzero moved this from Development 🐝 to Test 🕵 in Roadmap 🚀✨ Jan 19, 2025
@graciousgrey graciousgrey added tested Changes have been tested successfully and removed please-test Ready for acceptance test labels Jan 23, 2025
@graciousgrey graciousgrey moved this from Test 🕵 to Preview 🐳 in Roadmap 🚀✨ Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AsikNasik AsikNasik

Labels
enhancement Refactoring, improvement or maintenance task frontend Requires experience with HTML/JS/CSS tested Changes have been tested successfully ux Impacts User Experience
Projects
Roadmap 🚀✨
Status: Preview 🐳
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lastzero @graciousgrey @AsikNasik @omerdduran