Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn open task #1636

Merged
merged 27 commits into from
Sep 2, 2021
Merged

Spawn open task #1636

merged 27 commits into from
Sep 2, 2021

Conversation

jawira
Copy link
Contributor

@jawira jawira commented Sep 1, 2021

Hello, I modified OpenTask a little bit:

  • Everything works as expected when I open an url. But when I open a file, for example an image, the program blocks the terminal until the program is closed. That's why I added "spawn=true" option.
  • I added "passthru=false" to hide any message in console.

jawira and others added 27 commits February 11, 2019 14:27
@mrook mrook merged commit eb68f16 into phingofficial:main Sep 2, 2021
mrook added a commit that referenced this pull request Sep 2, 2021
@mrook
Copy link
Member

mrook commented Sep 2, 2021

I clicked merge too fast. This PR breaks the third test case in OpenTaskTest. Can you take a look at that @jawira ?

@jawira
Copy link
Contributor Author

jawira commented Sep 2, 2021

@mrook my fault, I will check that tonight.

@jawira jawira deleted the spawn-open-task branch September 5, 2021 07:39
@mrook mrook added this to the 3.0.0-RC4 milestone Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants