Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable properties which could not expanded should be null. #1393

Merged
merged 4 commits into from
Sep 21, 2020

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Sep 18, 2020

After we discovered that we have an expandable variable, we give it back unchecked. We should return null in case of having a not expandable property.

Fixes #1391

@siad007 siad007 added this to the 3.0.0-rc1 milestone Sep 18, 2020
@jawira
Copy link
Contributor

jawira commented Sep 19, 2020

I tested with my code and it works, thank you 🎉

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #1393 into master will decrease coverage by 0.01%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1393      +/-   ##
============================================
- Coverage     53.06%   53.04%   -0.02%     
- Complexity     9306     9308       +2     
============================================
  Files           477      477              
  Lines         22689    22691       +2     
============================================
- Hits          12040    12037       -3     
- Misses        10649    10654       +5     
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/ext/HttpGetTask.php 82.60% <87.50%> (ø) 20.00 <6.00> (ø)
classes/phing/PropertyHelper.php 82.73% <100.00%> (+0.20%) 67.00 <0.00> (+2.00)
classes/phing/tasks/ext/HttpTask.php 91.11% <100.00%> (ø) 19.00 <0.00> (ø)
classes/phing/util/SourceFileScanner.php 61.76% <0.00%> (-7.36%) 21.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 258decd...1952562. Read the comment docs.

@siad007 siad007 merged commit c8c78b5 into phingofficial:master Sep 21, 2020
@siad007 siad007 deleted the HttpGetTask branch September 21, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Error resolving proxy
2 participants