Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoveTask] Fixed default overwrite behavior. #1268

Merged
merged 1 commit into from
Feb 16, 2020
Merged

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Feb 16, 2020

As seen in the manual - overwrite should be turned on by default.

overwrite should be turned on by default
@codecov
Copy link

codecov bot commented Feb 16, 2020

Codecov Report

Merging #1268 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1268      +/-   ##
============================================
+ Coverage     51.49%   51.52%   +0.03%     
- Complexity     9320     9321       +1     
============================================
  Files           480      480              
  Lines         22859    22862       +3     
============================================
+ Hits          11771    11780       +9     
+ Misses        11088    11082       -6
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/system/MoveTask.php 65.04% <100%> (+1.04%) 41 <1> (+1) ⬆️
classes/phing/tasks/system/CopyTask.php 81.19% <0%> (+2.75%) 90% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d0bec...ceafa51. Read the comment docs.

@siad007 siad007 merged commit 0a8746a into master Feb 16, 2020
@siad007 siad007 deleted the siad007-patch-1 branch February 16, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant