Rename __import method #1143
Merged
Rename __import method #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… work (from main directory instead)
… work (from main directory instead)
…uble underscore prefix for future use and this causes a conflict.
Codecov Report
@@ Coverage Diff @@
## master #1143 +/- ##
=========================================
Coverage 47.02% 47.02%
Complexity 9968 9968
=========================================
Files 505 505
Lines 24489 24489
=========================================
Hits 11515 11515
Misses 12974 12974
Continue to review full report at Codecov.
|
siad007
requested changes
Oct 2, 2019
README.md
Outdated
| Should this not work, you might be able to run the unit tests from the main directory: | ||
|
|
||
| $ $ ./bin/phing -f test/build.xml -Dtest=NotifyTaskTest | ||
|
|
There was a problem hiding this comment.
My bad - that was a straggler from a previous PR, removed it now.
siad007
approved these changes
Oct 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename __import method as PHP has reserved all method names with a double underscore prefix for future use and this causes a conflict