Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced copy paste #1118

Merged
merged 1 commit into from
Aug 10, 2019
Merged

Reduced copy paste #1118

merged 1 commit into from
Aug 10, 2019

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Aug 10, 2019

No description provided.

@siad007 siad007 added core cleanup code cleanup labels Aug 10, 2019
@siad007 siad007 added this to the 3.0.0-alpha3 milestone Aug 10, 2019
@codecov
Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #1118 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1118      +/-   ##
============================================
+ Coverage      46.9%   46.91%   +<.01%     
+ Complexity     9980     9975       -5     
============================================
  Files           505      505              
  Lines         24512    24502      -10     
============================================
- Hits          11498    11494       -4     
+ Misses        13014    13008       -6
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/system/RecorderEntry.php 60.41% <100%> (-1.85%) 45 <0> (-5)
.../phing/tasks/ext/phploc/PHPLocFormatterFactory.php 82.6% <0%> (-4.35%) 5% <0%> (ø)
classes/phing/listener/DefaultLogger.php 21.79% <0%> (+6.41%) 36% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8144fc3...8d53598. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 10, 2019 •
edited
Loading

Codecov Report

Merging #1118 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1118      +/-   ##
============================================
+ Coverage      46.9%   46.91%   +<.01%     
+ Complexity     9980     9975       -5     
============================================
  Files           505      505              
  Lines         24512    24502      -10     
============================================
- Hits          11498    11494       -4     
+ Misses        13014    13008       -6
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/system/RecorderEntry.php 60.41% <100%> (-1.85%) 45 <0> (-5)
.../phing/tasks/ext/phploc/PHPLocFormatterFactory.php 82.6% <0%> (-4.35%) 5% <0%> (ø)
classes/phing/listener/DefaultLogger.php 21.79% <0%> (+6.41%) 36% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8144fc3...8d53598. Read the comment docs.

@siad007 siad007 merged commit 9daf4a8 into master Aug 10, 2019
@siad007 siad007 deleted the siad007-patch-1 branch August 10, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cleanup code cleanup core
Milestone
3.0.0-alpha3
Development

Successfully merging this pull request may close these issues.
1 participant
@siad007