Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made some args optional. #1058

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Made some args optional. #1058

merged 1 commit into from
Apr 19, 2019

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Apr 19, 2019

Related to #1034

@siad007 siad007 added cleanup code cleanup core labels Apr 19, 2019
@siad007 siad007 added this to the 3.0.0-alpha3 milestone Apr 19, 2019
@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #1058 into master will decrease coverage by <.01%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1058      +/-   ##
============================================
- Coverage     46.65%   46.65%   -0.01%     
- Complexity    10029    10032       +3     
============================================
  Files           505      505              
  Lines         24457    24464       +7     
============================================
+ Hits          11410    11413       +3     
- Misses        13047    13051       +4
Impacted Files Coverage Δ Complexity Δ
classes/phing/types/AbstractFileSet.php 71.79% <63.63%> (-1.08%) 89 <21> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 386a9cb...f80e982. Read the comment docs.

@siad007 siad007 merged commit d1070f7 into master Apr 19, 2019
@siad007 siad007 deleted the siad007-patch-1 branch April 19, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup core
Development

Successfully merging this pull request may close these issues.

1 participant