Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contains and Containsregexp fail vs folder on Windows (Trac #1047) #560

Closed
phing-issues-importer opened this issue Oct 9, 2016 · 7 comments

Comments

@phing-issues-importer
Copy link

phing-issues-importer commented Oct 9, 2016

These two task will fail under Windows, since they will blindly try to fopen every path, regardless they're files or folders.
Under *NIX system everything is ok, but under Windows this will raise a "Permission denied" error when the task is trying to check a folder.

Migrated from https://www.phing.info/trac/ticket/1047

{
    "status": "new", 
    "changetime": "2013-09-19T01:51:41", 
    "description": "These two task will fail under Windows, since they will blindly try to fopen every path, regardless they're files or folders.  \nUnder *NIX system everything is ok, but under Windows this will raise a \"Permission denied\" error when the task is trying to check a folder.", 
    "reporter": "tampe125@gmail.com", 
    "cc": "", 
    "resolution": "", 
    "_ts": "1379555501850088", 
    "component": "phing-core", 
    "summary": "Contains and Containsregexp fail vs folder on Windows", 
    "priority": "tbd", 
    "keywords": "", 
    "version": "2.6.1", 
    "time": "2013-09-08T09:30:31", 
    "milestone": "Backlog", 
    "owner": "mrook", 
    "type": "defect"
}
@phing-issues-importer
Copy link
Author

phing-issues-importer commented Oct 9, 2016

Trac update at 20130909T14:31:44: mrook commented:

Could you provide a sample/test build file? Thanks!

@phing-issues-importer
Copy link
Author

phing-issues-importer commented Oct 9, 2016

Trac update at 20130910T09:36:46: tampe125@gmail.com commented:

Build file snippet:

<zipme basedir="${dirs.component}" destfile="${dirs.release}/release.zip" includeemptydirs="true">
    <fileset dir="${dirs.component}">
        <exclude name="media/photos/**"/>

        <not>
           <contains text="ProVersion" casesensitive="false" />
        </not>
    </fileset>
</zipme>

My folder tree:

component
 `-- backend
   `-- folder_1
   `-- folder_2
   `-- folder_3
     `-- symlinked_folder
 `-- frontend

I get the fatal error on symlinked_folder

@phing-issues-importer
Copy link
Author

phing-issues-importer commented Oct 9, 2016

Trac update at 20130915T14:42:49: tampe125@gmail.com commented:

Hello, can you confirm this bug report?
Is happening to you, too, or it's just me?

@phing-issues-importer
Copy link
Author

phing-issues-importer commented Oct 9, 2016

Trac update at 20130919T01:51:41:

  • mrook commented:

I'm not able to test it right now, I'll get back to you once I can!

  • mrook changed summary from "Contanins and Containsregexp fail vs folder on Windows" to "Contains and Containsregexp fail vs folder on Windows"

@mrook mrook removed their assignment Nov 17, 2016
@mrook
Copy link
Member

mrook commented Mar 24, 2017

@siad007 you use Windows right? Can you maybe test whether this issue still occurs?

@siad007
Copy link
Member

siad007 commented Apr 8, 2017

@mrook

I get the fatal error on symlinked_folder

Instead of a fatal error, a BuildException with Could not read file symlinked_folder is thrown.

@stale
Copy link

stale bot commented Feb 13, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 13, 2018
siad007 added a commit to siad007/phing that referenced this issue Apr 2, 2018
@siad007 siad007 mentioned this issue Apr 2, 2018
siad007 added a commit to siad007/phing that referenced this issue Apr 2, 2018
siad007 added a commit to siad007/phing that referenced this issue Apr 2, 2018
siad007 added a commit to siad007/phing that referenced this issue Apr 2, 2018
@mrook mrook closed this as completed in #904 Apr 4, 2018
mrook pushed a commit that referenced this issue Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants