Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: units table multiple analyte display & results only working for all analytes with same units #222

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Bug: units table multiple analyte display & results only working for all analytes with same units #222

wants to merge 8 commits into from
+91 −64

Conversation

Gero1999
Copy link
Collaborator

@Gero1999 Gero1999 commented Feb 25, 2025 •
edited
Loading

Issue

Closes #218

Description

When running a multiple analyte study the table displayed to indicate the units is unnecessarily repeated, which can be confusing for the user.

Definition of Done

  • Units table is not replicated per analyte when selecting both in the module message "Units Table"
  • Using different units per analyte will show up in results accordingly

How to test

Map data > NCA setup > Select all analytes in input > Units Table button
Then play with it to see it works and does not crush easily. After that
Run NCA > Check results

How to test features not covered by unit tests.

Contributor checklist

  • Code passes lintr checks
  • Code passes all unit tests
  • New logic covered by unit tests
  • New logic is documented
  • Package version is incremented

Notes to reviewer

Anything that the reviewer should know before tacking the pull request?

@Gero1999 Gero1999 linked an issue Feb 25, 2025 that may be closed by this pull request
Bug: Units table for multiple analyte is duplicated #218
Open
1 task
@Gero1999 Gero1999 changed the title Bug/units table multiple an display Bug/units table multiple analyte display & with different units Feb 25, 2025
@Gero1999 Gero1999 changed the title Bug/units table multiple analyte display & with different units Bug/units table multiple analyte display & results with different units per analyte Feb 25, 2025
@Gero1999 Gero1999 marked this pull request as ready for review February 25, 2025 15:21
@Gero1999 Gero1999 changed the title Bug/units table multiple analyte display & results with different units per analyte Bug: units table multiple analyte display & results with different units per analyte Feb 25, 2025
@Gero1999 Gero1999 changed the title Bug: units table multiple analyte display & results with different units per analyte Bug: units table multiple analyte display & results only working for all analytes with same units Feb 25, 2025
@Gero1999
Copy link
Collaborator Author

Gero1999 commented Feb 25, 2025 •
edited
Loading

Hey I just solved these two specific bugs, as we need them for the next deadline. I will make a separate issue for the specific problem with table units in Results, as we are doubting on what to do with that one.

Let me know your thoughts on the implementation! After approval I will increment the package version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-kolomanski m-kolomanski Awaiting requested review from m-kolomanski

@js3110 js3110 Awaiting requested review from js3110

@Gotfrid Gotfrid Awaiting requested review from Gotfrid

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Units table for multiple analyte is duplicated
1 participant
@Gero1999