Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added destroyForcibly parameter #9

Closed
wants to merge 1 commit into from
Closed

Conversation

KamilKurde
Copy link

for determining how process destruction should be handled in case of job cancellation, because of vararg as the first parameter and named arguments with default values this change is backwards compatible, it doesn't break existing code because by default process destruction is handled in the old way (by destroy() method)

… should be handled in case of job cancellation
Copy link
Owner

@pgreze pgreze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KamilKurde thank you for your contribution!

@pgreze
Copy link
Owner

pgreze commented Aug 13, 2021

Formatting is incorrect and failing the build. Let me introduce this change in #10

@pgreze pgreze closed this Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants