Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @JvmOverloads to process function #19

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Add @JvmOverloads to process function #19

merged 1 commit into from
Dec 16, 2022

Conversation

pgreze
Copy link
Owner

@pgreze pgreze commented Dec 16, 2022

Fix this error when upgrading the library used by other dependencies not updated yet:

java.lang.NoSuchMethodError: 'java.lang.Object com.github.pgreze.process.ProcessKt.process$default(java.lang.String[], com.github.pgreze.process.InputSource, com.github.pgreze.process.Redirect, com.github.pgreze.process.Redirect, java.util.Map, java.io.File, boolean, kotlin.jvm.functions.Function2, kotlin.coroutines.Continuation, int, java.lang.Object)'

See https://gist.github.com/pgreze/a40ba2a410a545773d089271fd6b48e0 for how to reproduce

@pgreze pgreze marked this pull request as ready for review December 16, 2022 08:20
@github-actions
Copy link

Unit Test Results

24 tests  ±0   24 ✔️ ±0   4s ⏱️ ±0s
  7 suites ±0     0 💤 ±0 
  7 files   ±0     0 ±0 

Results for commit 689578b. ± Comparison against base commit 5fa667d.

@codecov-commenter
Copy link

Codecov Report

Base: 84.33% // Head: 84.33% // No change to project coverage 👍

Coverage data is based on head (689578b) compared to base (5fa667d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #19   +/-   ##
=========================================
  Coverage     84.33%   84.33%           
  Complexity        3        3           
=========================================
  Files             4        4           
  Lines            83       83           
  Branches         29       29           
=========================================
  Hits             70       70           
  Misses            1        1           
  Partials         12       12           
Impacted Files Coverage Δ
...c/main/kotlin/com/github/pgreze/process/Process.kt 82.35% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pgreze pgreze merged commit 3f0fb93 into main Dec 16, 2022
@pgreze pgreze deleted the add-jvm-overloads branch December 16, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants