Skip to content

Commit

Permalink
Eagerly evaluate /tikz/rotate fit #1071
Browse files Browse the repository at this point in the history 
Co-authored-by: muzimuzhi <muzimuzhi@gmail.com>
Signed-off-by: Henri Menke <henri@henrimenke.de>
  • Loading branch information
@hmenke @muzimuzhi
hmenke and muzimuzhi committed Nov 9, 2021
1 parent 80c4ebf commit bcc8d26
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions tex/generic/pgf/frontendlayer/tikz/libraries/tikzlibraryfit.code.tex
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,12 @@

\ProvidesFileRCS{tikzlibraryfit.code.tex}

\pgfkeys{/tikz/fit/.code=\tikz@lib@fit{#1},
/tikz/rotate fit/.code=\def\tikz@lib@fit@rotate{#1}\pgfkeysalso{/tikz/rotate=#1}
\pgfqkeys{/tikz}{%
fit/.code=\tikz@lib@fit{#1},
rotate fit/.code={%
\pgfmathsetmacro\tikz@lib@fit@rotate{#1}%
\pgfkeysalso{/tikz/rotate=\tikz@lib@fit@rotate}%
},
}%

\def\tikz@lib@fit@rotate{0}%
Expand All @@ -21,8 +25,6 @@
\pgf@yb=-16000pt\relax%
\pgf@ya=16000pt\relax%
%
\pgfmathsetmacro\tikz@lib@fit@rotate{\tikz@lib@fit@rotate}%
%
% Now iterate over the coordinates
\tikz@lib@fit@scan#1\pgf@stop%
% Now, let's see what has happened
Expand Down

3 comments on commit bcc8d26

@muzimuzhi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tex4ht fails (link)

Run texlua build.lua manual tex4ht
[STATUS]  make4ht: Conversion started
[STATUS]  make4ht: Input file: pgfmanual.tex
[WARNING] tocid: char-def module not found
[WARNING] tocid: cannot fix section id's
[ERROR]   htlatex: Compilation errors in the htlatex run
[ERROR]   htlatex: Filename	Line	Message
[ERROR]   htlatex: ?	246	 Extra \else.

@hmenke
Copy link
Member Author

@hmenke hmenke commented on bcc8d26 Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But is this really due to this code change? Probably tex4ht is just broken again.

@muzimuzhi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya it's tex4ht's fault.

Please sign in to comment.