Support REPL command history. #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses #2019 |
kaos
approved these changes
Dec 30, 2022
When running a REPL via Pex (e.g., with Pants's repl goal), it can be useful to support command history. Python normally sets up command history by default when the interpreter imports `site`, but Pex bypasses that. So this change re-introduces the suggested idiom for loading and saving history, per https://docs.python.org/3/library/readline.html#example
jsirois
reviewed
Jan 1, 2023
jsirois
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a REPL via Pex (e.g., with Pants's repl goal), it can be useful to support command history.
Python normally sets up command history by default when the interpreter imports
site, but Pex bypasses that. So this change re-introduces the suggested idiom for loading and saving history, per https://docs.python.org/3/library/readline.html#exampleAlso replace a few hardcoded forward-slashed paths with os.path.sep.