Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Navigation Feature Implementation #166

Closed

Conversation

hunminkim98
Copy link
Contributor

Hello Dr. David,

This is the Tab Navigation Feature you suggested in a previous PR.

Here are the details:
Tab Key Navigation

  • Implemented proper cycling through person IDs when pressing the Tab key
  • Added temporary selection highlighting that shows users which ID they're currently viewing
  • Ensured Enter key correctly confirms the selection

Resolved Hover Effect Issues

  • Fixed the conflict between mouse hover and tab navigation
  • Implemented a mechanism to temporarily disable mouse hover effects during tab navigation

I hope these modifications meet your expectations!
Thank you for your time and suggestions. Have a great weekend!

Best regards,
HunMin Kim

… & Down, and remove the on_key function. This should resolve a minor error and improve the UI's responsiveness when updating the textbox value.
@davidpagnon
Copy link
Collaborator

Hi HunMin,

It is almost what I had in mind, but not a hundred percent, and it is still a bit buggy. Shift+tab is not enabled, it skips the OK button, and does not work on the first screen. See the attached video for what I was hoping for:

Enregistrement.de.l.ecran.2025-03-20.005957.mp4

To be honest, I don't think you are the problem, but rather that Matplotlib is. It is not originally made for building GUIs and is consequently not very good at it. It is slow and very complex to add any "simple" feature like this. I propose to table this issue and forget it until we come up with a different GUI that will handle keyboard navigation by itself. What do you think?

@hunminkim98
Copy link
Contributor Author

hunminkim98 commented Mar 20, 2025

Dear Dr. David,

Thanks for testing and for your time!
You're right, that's not the finished version. Also, there are some bugs that I can't fix yet (they're more complicated than I expected).

Thanks for sharing this video! It's much clearer now :)
I completely agree with you. Matplotlib isn't the best for GUI, and adding more features would make it slower and more challenging to maintain. I agree with your assessment and suggestion!!

@davidpagnon
Copy link
Collaborator

I'm closing it for now, then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants