Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar errors #4977

Merged
merged 12 commits into from
Jan 11, 2025
Merged

Fix grammar errors #4977

merged 12 commits into from
Jan 11, 2025

Conversation

Marcofann
Copy link
Contributor

@Marcofann Marcofann commented Jan 2, 2025

This pull request addresses several grammar issues across multiple files in the repository. The changes include corrections such as replacing "a" with "an" where appropriate (e.g., before words starting with vowel sounds) and fixing typos or inconsistencies in documentation and comments.

Files Updated

  1. chandelier.rs
    • Fixed: "an superfluous" → "a superfluous."
  2. path_search.rs
    • Fixed: "a inclusive" → "an inclusive."
  3. r1cs.rs
    • Fixed: "a individual" → "an individual."
  4. addresses.md
    • Fixed: "a address" → "an address."
  5. system_mapping.md
    • Fixed: "an bound" → "a bound."

Checklist Before Review

  • Updated grammar errors in all relevant files.
  • Verified that no other grammatical inconsistencies remain in the affected areas.
  • Added guiding comments for reviewers to verify changes.

Testing Notes

No code changes affecting functionality were made, so no unit tests were added. These changes only affect comments and documentation, ensuring clarity and accuracy.

Signed-off-by: Marco <wudmytrotest200@gmail.com>
Signed-off-by: Marco <wudmytrotest200@gmail.com>
Signed-off-by: Marco <wudmytrotest200@gmail.com>
Signed-off-by: Marco <wudmytrotest200@gmail.com>
Signed-off-by: Marco <wudmytrotest200@gmail.com>
Signed-off-by: Marco <wudmytrotest200@gmail.com>
Signed-off-by: Marco <wudmytrotest200@gmail.com>
Signed-off-by: Marco <wudmytrotest200@gmail.com>
@hdevalence
Copy link
Member

Thanks! The files under proto/src/gen are generated and should not be edited.

Signed-off-by: Marco <wudmytrotest200@gmail.com>
Signed-off-by: Marco <wudmytrotest200@gmail.com>
Signed-off-by: Marco <wudmytrotest200@gmail.com>
Signed-off-by: Marco <wudmytrotest200@gmail.com>
@Marcofann
Copy link
Contributor Author

Hi @hdevalence,

Thank you for the review! I have made the requested changes:

  • I restored the original state of the files in the proto/src/gen folder.

Let me know if anything else needs to be adjusted. Thank you!

Copy link
Member

@erwanor erwanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tyty!

@erwanor erwanor merged commit c90fa23 into penumbra-zone:main Jan 11, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants