fix(pd): drop unused snapshots #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
reviewed
Jul 25, 2023
crates/bin/pd/src/info/oblivious.rs
Outdated
Comment on lines
266
to
267
| // Don't let the block hang around while we serve other clients. | ||
| std::mem::drop(block); |
There was a problem hiding this comment.
This isn't necessary, because the compact block doesn't have any shared references in it, and the explicit drop distracts from the case that is important (dropping the snapshot)
Used this script to generate loadtests against a local pd instance, for memory profiling efforts. Steps I used to test: pd testnet unsafe-reset-all pd testnet join https://rpc.testnet-preview.penumbra.zone # start pd & tendermint, wait for genesis to complete ./deployments/scripts/pcli-client-test -n 1000 -p 100 Refs #2867.
Trying to resolve a memory leak in pd. These manual drops are a first pass, and appear to reduce memory consumption, but there's still a leak, according to bytehound. We'll continue to investigate. Includes a missed `to_proto` that's a nice to have, but likely doesn't- constitute a fix for our problem. Refs #2867. Co-Authored-By: Henry de Valence <hdevalence@penumbralabs.xyz>
conorsch
force-pushed
the
debug-pd-mem-consumption
branch
from
54a7c8e to
ed6d38c
Compare
conorsch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to resolve a memory leak in pd. These manual drops are a first pass, and appear to reduce memory consumption, but there's still a leak, according to bytehound. We'll continue to investigate.
Includes a missed
to_protothat's a nice to have, but likely doesn't constitute a fix for our problem.Refs #2867.
Used this script to generate loadtests against a local pd instance, for memory profiling efforts. Steps I used to test:
Refs #2867.