Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc: pcli transaction withdraw: change source-channel to channel #2864

Merged
merged 2 commits into from
Jul 22, 2023
Merged

ibc: pcli transaction withdraw: change source-channel to channel #2864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f5bd38
ibc: pcli transaction withdraw: change source-channel to channel
avahowell Jul 22, 2023
864d0b7
update ICS-20 withdrawal helptext
avahowell Jul 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions crates/bin/pcli/src/command/tx.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,18 +162,14 @@ pub enum TxCmd {
Sweep,

/// Perform an ICS-20 withdrawal, moving funds from the Penumbra chain
/// to a counterparty chain. Destination addresses must be specified as
/// 'address@chain-id`, where the `address` is of the appropriate format
/// the counterparty chain, and `chain-id` is the current identifier
/// for the counterparty chain.
/// to a counterparty chain.
///
/// For a withdrawal to succeed, relayer software must be configured to recognize
/// build paths between the two chains. Running a relayer is out of scope
/// for the pcli tool.
/// For a withdrawal to be processed on the counterparty, IBC packets must be relayed between
/// the two chains. Relaying is out of scope for the `pcli` tool.
#[clap(display_order = 250)]
Withdraw {
/// Address on the receiving chain,
/// e.g. cosmos1grgelyng2v6v3t8z87wu3sxgt9m5s03xvslewd@cosmoshub-4
/// e.g. cosmos1grgelyng2v6v3t8z87wu3sxgt9m5s03xvslewd
#[clap(long)]
to: String,

Expand All @@ -183,7 +179,7 @@ pub enum TxCmd {
/// This channel must already exist, as configured by a relayer client.
/// You can search for channels via e.g. `pcli query ibc transfer channel-0`.
#[clap(long)]
source_channel: String,
channel: String,

#[clap(long, default_value = "0", display_order = 100)]
timeout_height: u64,
Expand Down Expand Up @@ -812,7 +808,7 @@ impl TxCmd {
value,
timeout_height,
timeout_timestamp,
source_channel,
channel,
source,
} => {
let destination_chain_address = to;
Expand Down Expand Up @@ -868,7 +864,7 @@ impl TxCmd {
timeout_height,
timeout_time: timeout_timestamp,
return_address: ephemeral_return_address,
source_channel: ChannelId::from_str(source_channel)?,
source_channel: ChannelId::from_str(channel)?,
source_port: PortId::from_str("transfer")?,
};

Expand Down
2 changes: 1 addition & 1 deletion deployments/relayer/configs/penumbra-preview.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"type": "penumbra",
"value": {
"key": "default",
"chain-id": "penumbra-testnet-ganymede-5334ae2e",
"chain-id": "penumbra-testnet-ganymede-f721fd94",
"rpc-addr": "https://rpc.testnet-preview.penumbra.zone:443",
"account-prefix": "penumbrav2t",
"keyring-backend": "test",
Expand Down