fix packet commitment paths: use sequences correctly
#2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the longer term, think we should probably move these commitment paths to |
conorsch
force-pushed
the
fix-packet-state-paths
branch
from
709c73b to
0fa0479
Compare
|
As usual, will merge this onto preview, and re-run the devnet/preview script locally to evaluate behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our packet commitment paths were wrong, because they were modeled on the IBC spec, which contains state commitment paths different than what is currently deployed in
ibc-go:https://github.com/cosmos/ibc/blob/854f2e13ccab539dd99d9889dd9367339875f73e/spec/core/ics-004-channel-and-packet-semantics/README.md?plain=1#L231
vs ibc-go:
https://github.com/cosmos/ibc-go/blob/56a519c188ae841818b9ecd11244240941cc5d90/modules/core/24-host/keys.go#L212
this PR brings the penumbra commitment paths inline with
ibc-go.Should address #2834, but let's avoid closing that issue until we confirm with testing.