Separate LeafNodes from values #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preston-evans98
force-pushed
the
main
branch
from
0e3d169 to
796f2a9
Compare
This was referenced Feb 21, 2023
plaidfinch
reviewed
Feb 21, 2023
This commit removes the `value` field from `LeafNode`, allowing values to be handled separately in the underlying data store. This allows very efficent `get` operations, since the tree no longer needs to be traversed in order to find the value of a given key. The tree is still traversed if a proof is requested.
preston-evans98
force-pushed
the
main
branch
from
3fe084e to
21d9d36
Compare
plaidfinch
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate LeafNodes from values
This PR removes the
valuefield fromLeafNode, allowing values to be handled separately in the underlying data store. This allows very efficentgetoperations, since the tree no longer needs to be traversed in order to find the value of a given key. The tree is still traversed if a proof is requested.