added request logging with response times #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejulius
requested changes
Oct 3, 2017
package.json
Outdated
| @@ -33,6 +33,8 @@ | |||
| "express": "^4.15.2", | |||
| "lodash": "^4.17.4", | |||
| "lower-case": "^1.1.4", | |||
| "morgan": "^1.9.0", | |||
| "pelias-logger": "^0.2.0", | |||
There was a problem hiding this comment.
use an exact version :) NPM doesn't by default
orangejulius
approved these changes
Oct 3, 2017
There was a problem hiding this comment.
Code looks good to me. Unfortunately the way the Travis tests are set up right now, they'll only ever pass on the same day we've pushed data. So either we merge anyway (the tests with the latest data passed on my machine), build new data, or figure out a new way to test.
ghost
removed
the
missinglink
reviewed
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.