Skip to content

Commit

Permalink
Clarify some comments
Browse files Browse the repository at this point in the history
Based on the info in this Qt blog post:
https://www.qt.io/blog/qt-on-apple-silicon
  • Loading branch information
pcolby committed Oct 5, 2024
1 parent ac1ce11 commit ceb77f9
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,8 @@ jobs:
- { cc: gcc-14, cxx: g++-14, coverage: false }
- { cc: gcc-14, cxx: g++-14, coverage: true }
exclude:
# GitHub's macOS 14+ gcc can only target arm64, but the Qt Online Installer only provides ARM64 for Qt 6.2+,
# so exclude Qt 5.x (and 6.1, 6.2) with GCC on macOS 14+. Also see the `arch` step below for more details.
# GitHub's macOS 14+ gcc can only target arm64, but Qt didn't add Apple arm64 support until Qt 6.2, so:
# Exclude Qt 5.x (and 6.0, 6.1) with GCC on macOS 14+. Also see the `arch` step below for more details.
- { qt: '5.9.9', os: macos-14, env: { cc: gcc-14 } }
- { qt: '5.9.9', os: macos-15, env: { cc: gcc-14 } }
- { qt: '5.10.1', os: macos-14, env: { cc: gcc-14 } }
Expand Down Expand Up @@ -212,7 +212,7 @@ jobs:
- name: Choose target architectures
id: arch
run: |
# Qt Online Installer only provides x86-64 binaries (not arm64) prior to Qt 6.2.0.
# Qt only supports x86-64 (not arm64) on macOS prior to Qt 6.2.0. See https://www.qt.io/blog/qt-on-apple-silicon
if [[ '${{ matrix.qt }}' =~ ^(5|6\.[01])\. ]]; then arch=x86_64
# GitHub runners' (homebrew'd) gcc's only support support x86-64 prior to macos-14, and only arm64 after.
# Note: if we attempt to use multiple archs, gcc will warn, but continue, resulting in later failures.
Expand Down

0 comments on commit ceb77f9

Please sign in to comment.