Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💥 Implement 0x00 Version of EIP-191 in ECDSA Library #81

Merged
merged 5 commits into from
Feb 22, 2023
Merged

💥 Implement 0x00 Version of EIP-191 in ECDSA Library #81

merged 5 commits into from
Feb 22, 2023

Conversation

YamenMerhi
Copy link
Contributor

@YamenMerhi YamenMerhi commented Feb 21, 2023 •
edited by pcaversaccio
Loading

CHANGELOG

  • Adding to_data_with_intended_validator_hash(validator: address, data: Bytes[1024]) function to ECDSA library to support constructing messages according to the version 0x00 of EIP-191.
  • Adding a utility function to_data_with_intended_validator_hash_self that considers the validator address as self to be used by other contracts willing to validate the data.

PR Checklist

@YamenMerhi
Copy link
Contributor Author

Linted before pushing but for some reason, it's marking nothing to be changed.

@pcaversaccio
Copy link
Owner

I will fix it before merging, don't worry about this.

@pcaversaccio pcaversaccio added the feature 💥 New feature or request label Feb 22, 2023
@pcaversaccio pcaversaccio added this to the 0.0.1 milestone Feb 22, 2023
@pcaversaccio pcaversaccio self-requested a review February 22, 2023 08:25
@pcaversaccio pcaversaccio self-assigned this Feb 22, 2023
@pcaversaccio pcaversaccio linked an issue Feb 22, 2023 that may be closed by this pull request
💥 Version 0x00 of EIP-191 in ECDSA Library Implementation #78
Closed
@pcaversaccio
🔨 some cleanup
939ed9c 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
🔨 bump submodules and add gas snapshot
2a71e57 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
🔨 refactor
15c0f5c 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
pcaversaccio
pcaversaccio approved these changes Feb 22, 2023
View reviewed changes
Copy link
Owner

@pcaversaccio pcaversaccio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR - I quickly refactored some small pieces, added further documentation, and abused this PR to bump the submodules :)

@pcaversaccio pcaversaccio merged commit 4e72c76 into pcaversaccio:main Feb 22, 2023
@pcaversaccio pcaversaccio added dependencies 🔁 Pull requests that update a dependency file refactor/cleanup ♻️ Code refactorings and cleanups labels Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcaversaccio pcaversaccio pcaversaccio approved these changes

Assignees

@pcaversaccio pcaversaccio

Labels
dependencies 🔁 Pull requests that update a dependency file feature 💥 New feature or request refactor/cleanup ♻️ Code refactorings and cleanups
Projects
None yet
Milestone
0.0.1
Development

Successfully merging this pull request may close these issues.

💥 Version 0x00 of EIP-191 in ECDSA Library Implementation
2 participants
@YamenMerhi @pcaversaccio