Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As brought up in #494, the
readthedocs
versions are1.1.5+0.g78f67ff.dirty
for1.1.5
. I think the reason why is due to new files during added during readthedocs build (docs/source/_build/
and_readthedocs/
), and auto-generated content is added todocs/source/conf.py
. Due to these modifications in the repository, when payu is imported indocs/source/conf.py
and the version is determined,versioneer
marks the versions asdirty
.To prevent this, I've added an local pip install of
payu
to run before the docs build step, so the version is unaffected by the modified files. The documentation build for this PR now has nodirty
tag: https://payu--505.org.readthedocs.build/en/505/.With some local testing, if an
1.1.5
tag is checked out, there a modification to a file and then payu is locally installed, the version is1.1.5+0.g78f67ff.dirty
(payu --version
). If there are no modifications, the version is1.1.5
.