Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
It seems that in the latest version of
pip
, we can no longer pass in a class intoinclude_dirs
that eventually resolves into a string. This was previously done because runningsetup.py
in a fresh environment would fail as numpy had not yet been installed. Therefore, we used a utilityget_numpy_include
class which would import numpy only when it was called, after numpy was already installed. This is apparently no longer supported.Related issue: #248
Failing tests in PR #246
Description of changes
This is most likely no longer needed because we now build using
pyproject.toml
, where we can pre-specify the build requirements, which will always be installed before thesetup.py
script is run. Therefore, we no longer need any checks if numpy is installed.Similarly, the
have_cython
check is no longer needed insetup.py
either, as we specify cython as a build dependency inpyproject.toml
.Includes