Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py maintenance #249

Merged
merged 5 commits into from
Aug 19, 2023
Merged

setup.py maintenance #249

merged 5 commits into from
Aug 19, 2023

Conversation

pavlin-policar
Copy link
Owner

Issue

It seems that in the latest version of pip, we can no longer pass in a class into include_dirs that eventually resolves into a string. This was previously done because running setup.py in a fresh environment would fail as numpy had not yet been installed. Therefore, we used a utility get_numpy_include class which would import numpy only when it was called, after numpy was already installed. This is apparently no longer supported.

Related issue: #248
Failing tests in PR #246

Description of changes

This is most likely no longer needed because we now build using pyproject.toml, where we can pre-specify the build requirements, which will always be installed before the setup.py script is run. Therefore, we no longer need any checks if numpy is installed.
Similarly, the have_cython check is no longer needed in setup.py either, as we specify cython as a build dependency in pyproject.toml.

Includes
  • Code changes
  • Tests
  • Documentation

@pavlin-policar pavlin-policar merged commit 9f83ab6 into master Aug 19, 2023
@pavlin-policar pavlin-policar deleted the fixes branch August 19, 2023 10:18
This was referenced Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant