A more reliable method to get the global object #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@david-risney, can you test this pr in a web worker, and confirm that it still works? |
|
Yep, looks good. I ran the worker test I had added with my previous change and it continues to pass with your change. |
ljharb
added a commit
that referenced
this pull request
Jun 12, 2014
A more reliable method to get the global object
|
work fine under node-webkit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #258.
This uses
evalvia theFunctionconstructor, which is awful, but I can't come up with a better method in strict mode. I could also do(function () { return this; }())in non-strict mode, but then I'd have to make the outer wrapper of the shim not be in strict mode.