Update fsevents dependency to use napi #774
Conversation
pipobscure
force-pushed
the
UpdateFSEvents
branch
from
f3f33a3 to
ad0e701
Compare
pipobscure
force-pushed
the
UpdateFSEvents
branch
from
ad0e701 to
fecf799
Compare
|
@paulmillr this is the current version to experiment with fsevents/fsevents#247 There are 2 test failures where the spy gets called twice rather than once and they are special-cased with This should bring us much closer to using NAPI as of April, when we have the backport of the things fsevents needs to v8.x (currently only v10.6+). (per nodejs/node#24249 ) My thought is to use the April EOL of v6 to release this all and limit it's compatibility to v8.x+ Comments? |
pipobscure
changed the title
|
Yeah, that sounds great. Do you have any idea why was the test coverage decreased? |
|
Sadly I have not. I’m just happy that it actually runs through all the tests. 😀 |
|
Merged in master. |
This updated the fsevents dependency to use the napi tagged version (currently 2.0.2-pre-1)
There are a few API changes, and support for node-versions below v8 has been dropped, whence the major version bump. (v8.x support is not there currently but will become available through nodejs/node#25002)
The big advantage of this is that fsevents is now using N-API which means a single build works with all versions of node. No more node-pre-gyp downloading specific versions and upgrading with every new node release.
In addition fsevents now uses a single runloop/thread to listen for events which makes it significantly cheaper; and it reduces the API to just handle the native stuff, which is all chokidar uses which leads to eliminating a
statcall per event, again making it a lot cheaper.I have also tested the regular binary against the upcoming version of electron (v4.0.0-beta7) and it works out of the box. So this should also eliminate some of the pain associated with that.