Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpret scalar transformations as diagonal #106

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

NeilGirdhar
Copy link
Contributor

No description provided.

Copy link
Owner

@patrick-kidger patrick-kidger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thank you for getting the tridiagonal one too, I hadn't noticed that a tridiagonal operator with length-zero off-diagonals should also be possible.

Would you be able to add some tests for this edge case?

@NeilGirdhar NeilGirdhar force-pushed the diagonal branch 2 times, most recently from e5c4538 to 2424368 Compare August 18, 2024 15:36
@NeilGirdhar
Copy link
Contributor Author

Would you be able to add some tests for this edge case?

Done

@patrick-kidger patrick-kidger merged commit 50f8b81 into patrick-kidger:main Aug 20, 2024
2 checks passed
@patrick-kidger
Copy link
Owner

LGTM - merged! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants