Add WiFi credential check #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtolstoy
requested changes
Feb 29, 2024
hal/network/ncp/wifi/wlan_hal.cpp
Outdated
| CHECK(mgr->setNetworkConfig(std::move(conf))); | ||
| return 0; | ||
| } | ||
| // Note: It's maily a copy of joinNewNetwork() in wifi_new.cpp |
There was a problem hiding this comment.
Let's have this functionality in a common function then shared by both wlan_hal and wifi_new.cpp ?
XuGuohui
force-pushed
the
feature/sc125680/wifi-credential-check
branch
from
7901ed4 to
349fede
Compare
avtolstoy
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
WiFi.setCredentials()doesn't verify if the credentials is valid or not.Solution
Add a new flag
WLAN_SET_CREDENTIALS_FLAGS_VALIDATEin WiFi credentials to optionally validate the credentials to be set.Steps to Test
Run the
tests/wiring/wifi_cred_checktestReferences
SC125680
Completeness