Disable direct logging in listening mode #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtolstoy
approved these changes
Aug 17, 2022
sergeuz
force-pushed
the
fix/disable_direct_logging_in_listening_mode
branch
from
ce833b7 to
720ab35
Compare
sergeuz
force-pushed
the
fix/disable_direct_logging_in_listening_mode
branch
from
720ab35 to
c310f79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Device OS disables logging to the USB serial when the device is in listening mode in order to prevent mixing up the serial console and logging output. However, it turns out that messages logged via
LOG_PRINT()and other macros for direct logging still get through and may garble the serial console output. This PR fixes that by disabling direct logging in listening mode.