Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] [esomx] disable RGB pwm channel(s) when running pwm tests #2494

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

scott-brust
Copy link
Member

@scott-brust scott-brust commented Jul 27, 2022

NOTE: This PR should also be backported to 4.x

Problem

wiring/no_fixture_long_running PWM tests are failing on esomx platform, specifically PWM tests with pin C5.
C5 shares a PWM channel with the RGB LEDs (channel 0). When running the PWM long running tests, the RGB led would interfere with the tests, causing them to fail.

Solution

Disabling the RGB LED during the PWM tests allows them to execute without the LED system interfering.

NOTE: this change does affect all PWM tests on all platforms, not just esomx

I tested this PR with esomx, p2 and boron platforms and all passed.

Steps to Test

Run wiring/no_fixture_long_running tests

Example App

Run wiring/no_fixture_long_running tests

References

Links to the Community, Docs, Other Issues, etc..


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@technobly technobly changed the title [test] [esomx] disable RGB pwm channel(s) when running pwm tests [tests] [esomx] disable RGB pwm channel(s) when running pwm tests Jul 27, 2022
@technobly technobly added this to the 5.0.0 milestone Jul 27, 2022
@scott-brust scott-brust merged commit 98c7b9f into develop Jul 27, 2022
@scott-brust scott-brust deleted the fix/esomx-pwm branch July 27, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants