Fix GCC platform on some versions of GCC; Fix wiring/api tests for P2; Fix building of wiring/api tests on CI #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtolstoy
force-pushed
the
fix/gcc-ci-tests
branch
from
69dfd7a to
6494b23
Compare
tstellanova
approved these changes
Jul 20, 2022
avtolstoy
force-pushed
the
fix/gcc-ci-tests
branch
from
6494b23 to
1ffa538
Compare
… ProtocolFactory type is also declared in global namespace. Some versions of GCC fail to resolve this operator through ADL if it's defined in an anonymous namespace
…vent references are optimized out, fix builds for GCC platform on certain versions of GCC (sic!)
…lt by release scripts
avtolstoy
force-pushed
the
fix/gcc-ci-tests
branch
from
1ffa538 to
f45f1bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As title says:
wiring/apitests on CIwiring/apitests for P2serialEventstuff and make sure unused serialEvent references are optimized outSteps to Test
Wait for CI build.
Completeness