[tinker] only include fqc functionality if APP=tinker #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtolstoy
approved these changes
Jul 19, 2022
License headers
scott-brust
changed the title
scott-brust
changed the title
avtolstoy
approved these changes
Jul 19, 2022
| * License along with this library; if not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| /* Includes ------------------------------------------------------------------*/ |
There was a problem hiding this comment.
Looks like an extra copy from somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Ensure FQC functionality is only compiled into tinker if built with
APP=tinker PLATFORM=p2All other builds will exclude it
Solution
Steps to Test
CI should pass
tinker release builds should include FQC functionality on P2 platform
tinker builds with APPDIR= should NOT include FQC
Example App
tinker
References
Completeness